Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopupWindow Improvements #1143

Open
3 of 10 tasks
ogoffart opened this issue Apr 4, 2022 · 3 comments
Open
3 of 10 tasks

PopupWindow Improvements #1143

ogoffart opened this issue Apr 4, 2022 · 3 comments
Labels
a:builtin elements The runtime data structures related to the items (mO,bT) bug Something isn't working enhancement New feature or request

Comments

@ogoffart
Copy link
Member

ogoffart commented Apr 4, 2022

There are some issues with the current PopupWindow

PopupWindow was just build for the need of the ComboBox and cannot really do much more.
We should probably consider having friendlier widgets such as Allowing Dialog, Window, ... as child that can be shown
Maybe having MessageBox or such.

@peterjc123
Copy link

peterjc123 commented Apr 11, 2023

@ogoffart Any update on this? As a desktop application, popups are often used to show info or fatal error messages. Without that, we can only use status bar, which leads to poor user experience. Issue 1 and 4 really need to be resolved for the popup windows to work. It seems that we have the Dialogs. https://slint-ui.com/releases/1.0.0/docs/slint/src/builtins/elements.html#dialog
Examples to use Dialogs:
https://github.com/slint-ui/slint/blob/master/examples/todo/rust/main.rs#L54-L67
https://github.com/slint-ui/slint/blob/master/examples/todo/ui/todo.slint#L23-L43

@peterjc123
Copy link

@ogoffart It seems that a Dialog still needs to wrapped in a PopupWindow, so that those issues still exist.

@hunger hunger added the a:widgets Implementation of widgets (from std-widgets.slint) and their styles (mF,bS) label Jul 18, 2023
@almindor
Copy link
Contributor

almindor commented Aug 20, 2023

NOTE: I'll make a separate issue once I isolate the problem but currently losing focus (app level) with PopupWindow being up when using Wayland/Sway session causes the popup window to close with a state loss if a state is associated (e.g. awaiting user decision). AFAIK there's no way to assign "this popup has closed for any reason" in a generic way to the popup window to count the user action (e.g. cancellation).

I haven't tested yet if the app-level focus loss does this on other session types, but in Sway it's very bothersome because all it takes is mouse movement. The popup window can also "outgrow" the parent main window so moving the mouse towards any buttons inside it can easily lead to focus loss on i3 like WMs.

@FloVanGH FloVanGH added a:builtin elements The runtime data structures related to the items (mO,bT) and removed a:widgets Implementation of widgets (from std-widgets.slint) and their styles (mF,bS) labels Jan 18, 2024
@ogoffart ogoffart added bug Something isn't working enhancement New feature or request labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:builtin elements The runtime data structures related to the items (mO,bT) bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants