Fixes #34 - Phoenix 1.3-rc compatability #37
Conversation
- credit goes to [KazW](slime-lang#35) for leading the effort - addressing the Phoenix alias of `:datetime` for `:naive_datetime` [source](https://github.com/phoenixframework/phoenix/blob/master/lib/mix/tasks/phx.gen.schema.ex#L30)
|
Wondering if we want to consider a version bump for this (lack of backward compatibility) |
| @@ -20,7 20,7 @@ defmodule PhoenixSlime.Mixfile do | |||
| end | |||
|
|
|||
| def deps do | |||
| [{:phoenix, "~> 1.2"}, | |||
| [{:phoenix, "~> 1.3-rc"}, | |||
There was a problem hiding this comment.
I think we can stick with~> 1.2 and use allow_pre: false, can't we?
There was a problem hiding this comment.
I'll test this out when I get a chance a bit later today, but not sure it's going to work, because the code changes expect that attrs/1 and params/1 be under Mix.Phoenix.Schema and not Mix.Phoenix anymore...
There was a problem hiding this comment.
Just as I suspected. The specs fail when attempting to do stick to ~> 1.2 with allow_pre: false
How would you like to proceed?
There was a problem hiding this comment.
We'll keep what you have @sudostack 👍
|
Sorry for the delays @sudostack, started a new job recently and it's keeping me busy 😀 One final comment and this is good to merge. Thanks again for your help! |
|
@doomspork no worries, Sean! You maintain a ton of projects, too, and congrats! :) |
wulymammoth
force-pushed
the
feature/phoenix_1.3rc_compatability
branch
3 times, most recently
from
50cbf9b
to
01e1002
Compare
|
Thank you again @sudostack 👍 |
:datetimefor:naive_datetimesource