Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using debug logs for db internal operations #289

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

diptanu
Copy link
Contributor

@diptanu diptanu commented Oct 31, 2024

Fixes #287

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 31, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2024

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added the enhancement New feature or request label Oct 31, 2024
Copy link
Collaborator

@criccomini criccomini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but going to give @rodesai a chance to weigh in, just in case info was really important for his use case.

@criccomini criccomini merged commit 5caf23f into slatedb:main Oct 31, 2024
6 checks passed
@criccomini
Copy link
Collaborator

Merged! Can revert if Rohan chimes in later.

@diptanu We are currently wrapping up for an 0.3 release, which will include TTL and atomic batch writes. This change will go out with that. I'm guessing within a week or two (maybe sooner).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress Logs
3 participants