Adds OTelTraceIdRatioBasedSampler #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t089
commented
Aug 22, 2024
Package.swift
Outdated
| .package(url: "https://github.com/slashmo/swift-w3c-trace-context.git", from: "1.0.0-beta.1"), | ||
| //.package(url: "https://github.com/slashmo/swift-w3c-trace-context.git", from: "1.0.0-beta.1"), | ||
| //.package(name: "swift-w3c-trace-context", path: "../swift-w3c-trace-context"), | ||
| .package(url: "https://github.com/t089/swift-w3c-trace-context.git", branch: "trace-id-bytes"), |
There was a problem hiding this comment.
Please see slashmo/swift-w3c-trace-context#18 for details on this
slashmo
reviewed
Sep 14, 2024
Sources/OTel/Tracing/Sampling/OTelTraceIdRatioBasedSampler.swift
Outdated
Show resolved
Hide resolved
Sources/OTel/Tracing/Sampling/OTelTraceIdRatioBasedSampler.swift
Outdated
Show resolved
Hide resolved
Tests/OTelTests/Tracing/Sampling/OTelTraceIdRatioBasedSamplerTests.swift
Outdated
Show resolved
Hide resolved
Tests/OTelTests/Tracing/Sampling/OTelTraceIdRatioBasedSamplerTests.swift
Outdated
Show resolved
Hide resolved
Sources/OTel/Tracing/Sampling/OTelTraceIdRatioBasedSampler.swift
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #131 /- ##
==========================================
Coverage 99.00% 99.01% 0.01%
==========================================
Files 65 68 3
Lines 1800 1831 31
==========================================
Hits 1782 1813 31
Misses 18 18 ☔ View full report in Codecov by Sentry. |
t089
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
OTelTraceIdRatioBasedSampler(see Spec).The sampler takes the last 8 bytes of the
TraceIDand interprets them as a singleUInt64value which is then used for the sampling decision. As long as those bytes are randomly distributed, this gives a deterministic, but random sampling decision.This also adds the Benchmark package to benchmark the implementation.At the moment, this draft makes use of a proposed breaking change inswift-w3c-trace-contextto avoid an allocation when accessing the bytes orTraceID: slashmo/swift-w3c-trace-context#18