[BUG] Save necessary _y info to remove need for _y #7417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
reviewed
Nov 23, 2024
There was a problem hiding this comment.
I think this should work!
I have added a companion test, which we could merge if this is the only problematic adapter: #7428
I do not approve as this is still a draft, but that is exactly what I had in mind when saying "decoupling", and I think this is also exhaustively addressing the locations in the adapter.
fkiraly
added
module:forecasting
|
@hudsonhoch, the new test in #7428 does not seem to pick up the Would you be able to have a look, and/or provide a test in this PR with your failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #7405
Discussion #6914
The bigger issue: #7416
What does this implement/fix? Explain your changes.
It's not necessary to save all of
_yand_X, but if memory conscious and usingset_config(remember_data=False)prediction methods will not work. So saving only the necessary info to allow prediction.What should a reviewer concentrate their feedback on?
_yand_Xinfo the way I am seems kind of arbitrary. Should everything go in_y_metadata(or the respective attribute for_X(if there is one)?Did you add any tests for the change?
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
sktimeroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference