Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Handle empty matrices when creating SOMA from Seurat #990

Merged
merged 5 commits into from
Feb 23, 2023

Conversation

mojaveazure
Copy link
Member

Seurat allows empty matrices for counts and scale.data
Empty matrices are defined as 0x0 or 1x1 with a value of NA
Use SeuratObject::IsMatrixEmpty to determine empty matrices
Skip writing empty matrices

fixes TileDB-Inc/tiledbsc#92

Seurat allows empty matrices for counts and scale.data
Empty matrices are defined as 0x0 or 1x1 with a value of NA
Use SeuratObject::IsMatrixEmpty to determine empty matrices
Skip writing empty matrices

fixes TileDB-Inc/tiledbsc#92
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

But I defer to @aaronwolen for final approval

apis/r/R/SOMA.R Outdated Show resolved Hide resolved
Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks @mojaveazure!

Could you bump the version to 0.1.22.9002 and update NEWS.md?

Update changelog
…-data/TileDB-SOMA into ph/fix/seurat-empty-matrices
@johnkerl johnkerl changed the title Handle empty matrices when creating SOMA from Seurat [r] Handle empty matrices when creating SOMA from Seurat Feb 23, 2023
@mojaveazure mojaveazure merged commit af50af9 into main-old Feb 23, 2023
@mojaveazure mojaveazure deleted the ph/fix/seurat-empty-matrices branch February 23, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants