Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow publishConfig.registry to be npm default registry when using Yarn berry #750

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Jul 16, 2024

Allow publishConfig.registry to be 'https://registry.npmjs.org'

Though I uses https://registry.npmjs.org/, but the default value does not include the trailing slash, so I'm going to change my package.json and live with it. 😄 Turns out both used in npm docs.

I didn't change isExternalRegistry utility, since I found it's used for different purpose #750 (comment)

Fixes #749

@mmkal
Copy link
Collaborator

mmkal commented Jul 16, 2024

Looking at the other usages of isExternalRegistry, I do think they would both benefit from this change being moved inside that helper. Otherwise it looks like we unnecessarily prompt for a username and don't enable 2FA by default. And I guess for consistency could add a test to the existing ones for isExternalRegistry too.

@fisker fisker marked this pull request as draft July 16, 2024 10:51
@fisker fisker marked this pull request as ready for review July 16, 2024 10:59
@fisker
Copy link
Contributor Author

fisker commented Jul 16, 2024

Updated.

Anyway I'm not familiar with codebase but seems we are not reading user .npmrc, so it can break edge cases.

Copy link
Collaborator

@mmkal mmkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure about .npmrc, but this is an improvement on the status quo

@sindresorhus sindresorhus merged commit 6c5eee3 into sindresorhus:main Jul 16, 2024
3 checks passed
@fisker fisker deleted the npm-default-registry branch July 17, 2024 01:46
Vylpes pushed a commit to Vylpes/vylbot-app that referenced this pull request Aug 6, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [np](https://github.com/sindresorhus/np) | devDependencies | patch | [`10.0.6` -> `10.0.7`](https://renovatebot.com/diffs/npm/np/10.0.6/10.0.7) |

---

### Release Notes

<details>
<summary>sindresorhus/np (np)</summary>

### [`v10.0.7`](https://github.com/sindresorhus/np/releases/tag/v10.0.7)

[Compare Source](sindresorhus/np@v10.0.6...v10.0.7)

-   Allow `publishConfig.registry` to be npm default registry when using Yarn berry ([#&#8203;750](sindresorhus/np#750))  [`6c5eee3`](sindresorhus/np@6c5eee3)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119-->

Reviewed-on: https://git.vylpes.xyz/RabbitLabs/vylbot-app/pulls/456
Reviewed-by: Vylpes <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Vylpes pushed a commit to Vylpes/random-bunny that referenced this pull request Aug 7, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [np](https://github.com/sindresorhus/np) | devDependencies | patch | [`10.0.5` -> `10.0.7`](https://renovatebot.com/diffs/npm/np/10.0.5/10.0.7) |

---

### Release Notes

<details>
<summary>sindresorhus/np (np)</summary>

### [`v10.0.7`](https://github.com/sindresorhus/np/releases/tag/v10.0.7)

[Compare Source](sindresorhus/np@v10.0.6...v10.0.7)

-   Allow `publishConfig.registry` to be npm default registry when using Yarn berry ([#&#8203;750](sindresorhus/np#750))  [`6c5eee3`](sindresorhus/np@6c5eee3)

### [`v10.0.6`](https://github.com/sindresorhus/np/releases/tag/v10.0.6)

[Compare Source](sindresorhus/np@v10.0.5...v10.0.6)

-   Fix usage with `pnpm` and `--any-branch` or `--branch` ([#&#8203;745](sindresorhus/np#745))  [`d0c1493`](sindresorhus/np@d0c1493)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy40MzEuNCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==-->

Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/189
Reviewed-by: Vylpes <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow publishConfig.registry to be npm default registry
3 participants