Add pre-publish task tests #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bunysae
commented
Mar 1, 2020
| stdout: '{"sindresorhus": "read"}' | ||
| } | ||
| ]); | ||
| process.env.NODE_ENV = 'P'; |
There was a problem hiding this comment.
Setting the NODE_ENV-environment-variable was necessary. Otherwise this task is always skipped
(see https://github.com/sindresorhus/np/blob/master/source/.prerequisite-tasks.js line 33).
When i put this environment-variable directly in ava-configuration, some other tests were broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #384. Stubs were created for the commands as mention in my comment.
The tests run serially because the stubbed
execa-dependency is cached when loaded the first time (see avajs/ava#1066 and https://nodejs.org/api/modules.html#modules_caching).IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor