Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the FreeBSD ifdef to Pathname::getThisExecutablePath() #672

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Add the FreeBSD ifdef to Pathname::getThisExecutablePath() #672

merged 1 commit into from
Aug 9, 2019

Conversation

yurivict
Copy link
Contributor

@yurivict yurivict commented Aug 8, 2019 •
edited by sherm1
Loading

This change is Reviewable

@yurivict yurivict mentioned this pull request Aug 8, 2019
Open
@sherm1 sherm1 self-assigned this Aug 8, 2019
sherm1
sherm1 reviewed Aug 8, 2019
View reviewed changes
Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sherm1 for review
Please confirm that you ran the tests locally and that they all pass now.
Travis build flaked out -- restarted. Will merge when that completes.

Pending confirmation and CI completion, :lgtm:. Will merge as soon as those are done -- thanks!

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @sherm1)

sherm1
sherm1 approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov-io
Copy link

Codecov Report

Merging #672 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672       /-   ##
==========================================
  Coverage   49.35%   49.35%    <.01%     
==========================================
  Files         556      556              
  Lines       71297    71299        2     
==========================================
  Hits        35191    35193        2     
  Misses      36106    36106
Impacted Files Coverage Δ
SimTKcommon/src/Pathname.cpp 87.3% <ø> (ø) ⬆️
SimTKcommon/src/ParallelExecutor.cpp 87.05% <0%> ( 0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94814f3...54f04cf. Read the comment docs.

@yurivict
Copy link
Contributor Author

yurivict commented Aug 8, 2019

With this patch I've ran the tests in the FreeBSD port, and they all passed now.

@sherm1
Copy link
Member

sherm1 commented Aug 9, 2019

Thanks, @yurivict !

@sherm1 sherm1 merged commit 12805f8 into simbody:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherm1 sherm1 sherm1 approved these changes

Assignees

@sherm1 sherm1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yurivict @codecov-io @sherm1