Fix Catalan hyphenations at geminated L #1964
Conversation
There was a problem hiding this comment.
I think my only concern with this and the other PR is the size of the test case. I would prefer if we could get in on A7 and adjust the font metrics until we had just a couple words and and absolute minimum of lines to exhibit the actual test subject. That makes it a lot easier to review both diffs of the debug file and the actual display PDF later when some minor metrics change affects things. These long lines on big pages add up to a lot of content to review hunting for the one syllable difference that may or may not matter.
Omikhleia
force-pushed
the
fix-catalan-hyphen-rule
branch
from
134d2a9
to
0cc7c7b
Compare
I amended my test commit to make it smaller and on A7
Would that be sufficient?
|
|
If I understand the test correctly the fixup commit I just sent should accomplish the same thing, save about 30 lines of diffs, and also be a lot easier to visually inspect later to see if the proper thing is still being tested. Can you give that a check to make sure I understood it correctly? |
Looks good to me! |
alerque
force-pushed
the
fix-catalan-hyphen-rule
branch
from
483e986
to
eb6f227
Compare
Closes #1961
Instal·lem SILE per a la llengua catalana!
And we are in advance, but happy Dia del Punt Volat on January 24 to our Catalan friends.