Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize/refactor language-specific discretionary handling #1966

Closed
Omikhleia opened this issue Jan 21, 2024 · 1 comment · Fixed by #1970
Closed

Generalize/refactor language-specific discretionary handling #1966

Omikhleia opened this issue Jan 21, 2024 · 1 comment · Fixed by #1970
Assignees
Labels
refactor Code quality improvements
Milestone

Comments

@Omikhleia
Copy link
Member

With Catalan, we now have another special case, similar to Turkish, of specific discretionary handling in core/hyphenator-liang.lua

I would suggest we discuss moving those in some dedicated language-specific classes for handling post-segmentation exceptions. Other noteworthy points

  • We should likely cache those discretionary nodes (here below and for Turkish as well), instead of rebuilding them each time they are needed...
  • Specific files for these hacks would need to use a language-based filename rather that merely comparing the language string. When supporting qualified BCP47 languages, we may want to distinguish ca (canonical Catalan = ca-ES) from ca-FR (as used in the French Pyrenees)...

Originally posted by @Omikhleia in #1964 (comment)

@alerque
Copy link
Member

alerque commented Jan 27, 2024

The main issue was addressed, but not the subpoints.

@alerque alerque modified the milestones: v0.x.y, v0.14.15 Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code quality improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants