Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ts:scripts: Use SOURCE_DATE_EPOCH env if available #6212

Closed
wants to merge 1 commit into from
Closed

ts:scripts: Use SOURCE_DATE_EPOCH env if available #6212

wants to merge 1 commit into from

Conversation

cryptomilk
Copy link
Contributor

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A yarn ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

For packaging you want to use the SOURCE_DATE_EPOCH environment variable as release tarballs don"t inlcude git information. The variable is widely available on different distributions.

Details: https://reproducible-builds.org/docs/source-date-epoch/

@cryptomilk cryptomilk mentioned this pull request Dec 14, 2022
Closed
7 tasks
@alvaro-signal
Copy link
Contributor

alvaro-signal commented Dec 15, 2022 •
edited
Loading

This change was already approved and the commits were merged internally from the previous PR. Thanks for your contribution, it will be in the next beta release. Closing this PR.

@cryptomilk
Copy link
Contributor Author

May I suggest that you only closes PRs once they show up in your main branch and thus are contributor visible. We do that as the Samba Team in our repository for contributions. We add a link to the commit so the contributor can see that his patch made it upstream. If you just close it and I update my local repo and see that the patch is not applied I wonder what went wrong.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cryptomilk @alvaro-signal