-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ts:scripts: Use SOURCE_DATE_EPOCH envionment variable if set #5753
Conversation
See https://reproducible-builds.org/docs/source-date-epoch/ Signed-off-by: Andreas Schneider <[email protected]>
8bbdebe
to
90ed90d
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Unstale, still valid ... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still valid ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This will be merged with the next beta release. Thanks!
Why was this closed without being merged? |
I created #6212 now. |
The Signal team generally uses private repositories for development. They will merge the commit(s) in your PR manually into their private repository, and once a (beta) release is ready, the commits for that release will be pushed to this public repository. Your PR won"t be marked as "merged", it will be closed, but the commit in the repository will have you as the author or co-author. There"s no need to open a duplicate PR. |
First time contributor checklist:
Contributor checklist:
development
branchyarn ready
run passes successfully (more about tests here)Description
For packaging you want to use the SOURCE_DATE_EPOCH environment variable as release tarballs don"t inlcude git information. The variable is widely available on different distributions.
Details: https://reproducible-builds.org/docs/source-date-epoch/