Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts:scripts: Use SOURCE_DATE_EPOCH envionment variable if set #5753

Closed
wants to merge 1 commit into from

Conversation

cryptomilk
Copy link
Contributor

First time contributor checklist:

Contributor checklist:

Description

For packaging you want to use the SOURCE_DATE_EPOCH environment variable as release tarballs don"t inlcude git information. The variable is widely available on different distributions.

Details: https://reproducible-builds.org/docs/source-date-epoch/

@cryptomilk cryptomilk force-pushed the asn-source-date-epoch branch from 8bbdebe to 90ed90d Compare January 21, 2022 13:01
@stale
Copy link

stale bot commented Aug 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 30, 2022
@cryptomilk
Copy link
Contributor Author

Unstale, still valid ...

@stale stale bot removed the stale label Aug 31, 2022
@stale
Copy link

stale bot commented Nov 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 29, 2022
@cryptomilk
Copy link
Contributor Author

Still valid ...

Copy link
Contributor

@indutny-signal indutny-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will be merged with the next beta release. Thanks!

@cryptomilk
Copy link
Contributor Author

Why was this closed without being merged?

@cryptomilk
Copy link
Contributor Author

cryptomilk commented Dec 14, 2022

I created #6212 now.

@awaitlink
Copy link
Contributor

awaitlink commented Dec 14, 2022

@cryptomilk

Why was this closed without being merged?

The Signal team generally uses private repositories for development. They will merge the commit(s) in your PR manually into their private repository, and once a (beta) release is ready, the commits for that release will be pushed to this public repository. Your PR won"t be marked as "merged", it will be closed, but the commit in the repository will have you as the author or co-author. There"s no need to open a duplicate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants