Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/menu-item): occasionally empty tooltips in menu-item #1370

Merged
merged 13 commits into from
Aug 29, 2024
Merged

fix(core/menu-item): occasionally empty tooltips in menu-item #1370

merged 13 commits into from
Aug 29, 2024

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Jul 3, 2024 •
edited
Loading

💡 What is the current behavior?

GitHub Issue Number: [IX-1249]

🆕 What is the new behavior?

  • innerText has been replaced by textContent (--> innerText is aware of the rendered appearance of text, while textContent
    is not)
  • textContent ignores HTML
  • BUT: If someone passes "This is a test

    text

    " --> "This is a testtext" would be shown on the tooltip -> there is no use-case for that?

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8c53b88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader marked this pull request as draft July 3, 2024 08:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited
Loading

Report of strictNullChecks (strictPropertyInitialization) check

Typescript check

You decreased the total number of errors in PR branch by 9 🎉

ESLint check

Total ESLint warnings are the same in both branches

nuke-ellington
nuke-ellington previously requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update build meta files

packages/core/src/components/menu-item/menu-item.tsx Outdated Show resolved Hide resolved
@nuke-ellington nuke-ellington mentioned this pull request Jul 3, 2024
Merged
8 tasks
@matthiashader matthiashader marked this pull request as ready for review July 8, 2024 04:39
@danielleroux danielleroux added this to the Next release milestone Jul 9, 2024
@danielleroux danielleroux removed this from the Next release milestone Jul 12, 2024
@TDaniel-evo TDaniel-evo mentioned this pull request Jul 12, 2024
Open
2 tasks
@matthiashader matthiashader changed the title fix(core/menu-item): fix empty tooltips fix(core/menu-item): occasionally empty tooltips in menu-item Aug 29, 2024
@danielleroux danielleroux merged commit 6965814 into main Aug 29, 2024
16 checks passed
@danielleroux danielleroux deleted the fix/1249-menu-item branch August 29, 2024 08:05
@github-actions github-actions bot mentioned this pull request Aug 29, 2024
Merged
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBerliner AndreasBerliner AndreasBerliner approved these changes

@nuke-ellington nuke-ellington Awaiting requested review from nuke-ellington

@danielleroux danielleroux Awaiting requested review from danielleroux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiashader @nuke-ellington @AndreasBerliner @danielleroux