fix(core): fix decoration offset edge cases #728
Merged
64
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes edge cases in the Decorations API.
Linked Issues
Fix #719 (when
offset === code.length
)Fix #727 (when
end.line < start.line
butend.offset > start.offset
)Additional context
It's recoverable when
end.line < start.line
if the offsets are okay. But because of the test explicitly checking that the chars don't overflow the line, I followed suit and threw instead of manipulating the line/character.