Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update doc about @shikijs plugins #721

Closed
wants to merge 3 commits into from
Closed

Conversation

fwqaaq
Copy link
Contributor

@fwqaaq fwqaaq commented Jul 24, 2024

Description

Add @shikijs plugins CDN link.

I don't know if Node supports CDN, and haven't added markdown-it?

Linked Issues

Additional context

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 2dddd44
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/66a07d90bb251f0008046251
😎 Deploy Preview https://deploy-preview-721--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 2dddd44
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/66a07d903803ec000836df11
😎 Deploy Preview https://deploy-preview-721--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fwqaaq fwqaaq marked this pull request as draft July 24, 2024 03:54
@fwqaaq fwqaaq changed the title chore: update doc about @shikijs/rehype plugin chore: update doc about @shikijs plugins Jul 24, 2024
@fwqaaq fwqaaq marked this pull request as ready for review July 24, 2024 04:09
@antfu
Copy link
Member

antfu commented Jul 24, 2024

Thank you. While I like esm.sh a lot, it's not the only CDN provider out there, and honestly, it isn't our responsibility to document it on every package - it should be part of the URL convensions.

@antfu antfu closed this Jul 24, 2024
@fwqaaq
Copy link
Contributor Author

fwqaaq commented Jul 24, 2024

Thank you. While I like esm.sh a lot, it's not the only CDN provider out there, and honestly, it isn't our responsibility to document it on every package - it should be part of the URL convensions.

If you publish it on jsr, you may not need to consider it. But when I use it in Deno, I would perfer to be able to directly get CDN URL, rather than having to search for each one individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants