Allow mapping values used in set through a function. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for you pr. You idea is nice. Please add tests, thanks. |
lightsofapollo
force-pushed
the
valueMapper
branch
from
a2ea6ee
to
213e688
Compare
lightsofapollo
force-pushed
the
valueMapper
branch
from
213e688
to
d1357f3
Compare
lightsofapollo
changed the title
|
@shepherdwind Thanks ! I have added tests and cleaned up some of the changes that were not needed. |
|
Also assuming these changes are good could you publish this in a new version? |
shepherdwind
approved these changes
Jun 12, 2018
| escape: true, | ||
| // 不需要转义的白名单 | ||
| unescape: {}, | ||
| valueMapper: value => value |
There was a problem hiding this comment.
Because This repo is very old, So code style is es5. If you add this array function, and the output code do not translate by babel. This may break on some old version browsers.
So, please write code in es5 only, thanks.
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows me to wrap my objects in a java like classes which gives us better compatibility with java VTL. If this approach is acceptable I will cleanup my PR and add tests.