Enh: deprecate legacy plots and code #3209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arshiaar
force-pushed
the
enh/deprecate-plots
branch
from
511960b
to
a04d9a5
Compare
dsgibbons
force-pushed
the
enh/deprecate-plots
branch
from
11a793e
to
5c994fd
Compare
|
Maybe update the message to say something like "will be removed in 0.44"? |
arshiaar
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3209 /- ##
==========================================
Coverage 57.58% 57.70% 0.11%
==========================================
Files 88 88
Lines 12511 12521 10
==========================================
Hits 7205 7225 20
Misses 5306 5296 -10
☔ View full report in Codecov by Sentry. |
thatlittleboy
requested changes
Aug 22, 2023
There was a problem hiding this comment.
Few suggestions (up for discussion, except the last one):
- Use the phrase "marked for deprecation" instead of "deprecated". I've always found it confusing myself, but maybe it's just me.
- Maybe
shap v0.43.0instead ofVersion 0.43.0. I'm thinking to specify "shap" because there might be wrapper libraries around shap, and I'm afraid end users will confuse 0.43 for the wrapper library's version rather than shap's. - Mention what the alternative should be. "Please use
shap.plots.barinstead" or words to that effect. For summary_legacy, maybe just nudge the user towards using the dedicated shap.plots functions. - The docstrings of the legacy functions should be updated as well with the deprecation message & reference to the suggested alternative, in a deprecation admonition / warning box.
thatlittleboy
added
awaiting feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Part of #3156
Description of the changes proposed in this pull request:
Potentially could create own decorator using the python warnings module.
Did not include unit tests for bar_legacy as function is breaking outside of decorator.
Checklist