Update _monitoring.py to prevent failure of monitoring_plot when sample size is <50. #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the 'inc' is greater than or equal to len(ys)-inc, the subsequent for loop does not run. Hence, the list pvals remains empty. As a result, np.min(pvals) fails resulting in failure of the entire monitoring_plot function. So, I corrected this error by allowing the user to choose 'inc' value at runtime by passing it as an argument to the function. Set the default value as 50 for backward compatibility. If (inc < len(ys)-inc), the t-test is skipped and a Warning is produced to prevent the failure of function of monitoring_plot.
55 tasks
connortann
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the sample size is <50, the 'inc' becomes greater than or equal to len(ys)-inc. As a result, the subsequent 'for loop' does not run. Hence, the list pvals remains empty. As a result, np.min(pvals) fails resulting in the failure of the entire monitoring_plot function. So, I corrected this error by adding a check before the for looop. If (inc < len(ys)-inc), the t-test is skipped and a Warning is produced to prevent the failure of function of monitoring_plot.
Also, added 'inc' in the function arguments to allow users to choose 'inc' value at runtime. Kept the default value of 'inc' as 50 for backward compatibility.