MAINT refactor feature_perturbation in Tree explainers #2624
72
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch between
"interventional"
to"tree_path_dependent"
being silent is quite surprising.Instead, I would propose to have an
"auto"
method that would switch to the method depending if the background dataset provided.Then when providing a specific algorithm, we will in the future raise an error if the conditions are not met to run the algorithm. For the moment, I propose to raise a
FutureWarning
to ask the user to change to"auto"
if this is really what they want (and therefore keep the code backward compatible).I find this way more explicit, knowing that
"tree_path_depedent"
might have an important impact on the symmetric axiom expected by the users.