MAINT refactor feature_perturbation in Tree explainers #2624
72
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2624 /- ##
==========================================
Coverage 51.61% 51.64% 0.03%
==========================================
Files 91 91
Lines 13146 13153 7
==========================================
Hits 6785 6793 8
Misses 6361 6360 -1 ☔ View full report in Codecov by Sentry. |
55 tasks
|
We appreciate your contribution! This Pull Request has been inactive for two years, so it's been automatically marked as 'stale'. Please leave a comment if you would still like the PR to remain open, and the 'stale' label will be removed. Otherwise, if there is no activity in the next 90 days the PR will be closed. |
github-actions
bot
added
the
stale
connortann
added
todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch between
"interventional"to"tree_path_dependent"being silent is quite surprising.Instead, I would propose to have an
"auto"method that would switch to the method depending if the background dataset provided.Then when providing a specific algorithm, we will in the future raise an error if the conditions are not met to run the algorithm. For the moment, I propose to raise a
FutureWarningto ask the user to change to"auto"if this is really what they want (and therefore keep the code backward compatible).I find this way more explicit, knowing that
"tree_path_depedent"might have an important impact on the symmetric axiom expected by the users.