Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read mysql bit type as i64 #661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

read mysql bit type as i64 #661

wants to merge 1 commit into from

Conversation

Cabbagec
Copy link
Contributor

@Cabbagec Cabbagec commented Jul 6, 2024

Currently, mysql column type MYSQL_TYPE_BIT is not supported, panicking the process if present in the table. And this issue is also stated in #359 and #491 .

I think it's appropriate to convert the bit type as longlong i64. According to the mysql doc page, bit type columns can store M-bit values, with M ranging from 1 to 64.

@wangxiaoying
Copy link
Contributor

Thanks @Cabbagec for the PR! Since it's a new type, can you also add it to our unit test? You can add a new column and insert some values in the mysql table defined here, and modify the unit corresponding tests here.

@Cabbagec
Copy link
Contributor Author

Cabbagec commented Jul 9, 2024

Thanks @Cabbagec for the PR! Since it's a new type, can you also add it to our unit test? You can add a new column and insert some values in the mysql table defined here, and modify the unit corresponding tests here.

Sure, will do later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cabbagec @wangxiaoying