Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine Docker-Hub does not work / API v1 no longer supported #4126

Closed
return42 opened this issue Dec 21, 2024 · 1 comment · Fixed by #4140
Closed

engine Docker-Hub does not work / API v1 no longer supported #4126

return42 opened this issue Dec 21, 2024 · 1 comment · Fixed by #4140
Labels
area: engine bug Something isn't working

Comments

@return42
Copy link
Member

Docker-Hub API v1 ..

searxng/searx/engines/docker_hub.py

Line 23 in 19ee529

search_url = base_url "api/content/v1/products/search?{query}&type=image&page_size=25"

does no longer work and the linked API docs no longer available

searxng/searx/engines/docker_hub.py

Line 13 in 19ee529

"official_api_documentation": 'https://docs.docker.com/registry/spec/api/',

Seems we need a response function like

base_url = "https://hub.docker.com/"
search_api = base_url   "api/search/v3/catalog/search?"
page_size = 10


def request(query, params):

    args = urlencode(
        {
            "query": query,
            "from": page_size * (params['pageno'] -1),
            "size": page_size,
        }
    )
    params['url'] = search_api   args
    params["headers"]["Search-Version"] = "v3"

    return params

.. the url is https://hub.docker.com/api/search/v3/catalog/search?query=searx&from=0&size=10

but this needs a new implementation of the response function and I don't know if there is a better solution ..

searxng/searx/engines/docker_hub.py

Lines 34 to 35 in 19ee529

def response(resp):
'''post-response callback

@return42 return42 added bug Something isn't working area: engine labels Dec 21, 2024
@Bnyro
Copy link
Member

Bnyro commented Dec 22, 2024 •
edited
Loading

I'm interested into look into this engine, but it'd probably be after the Christmas days then.

@Bnyro Bnyro mentioned this issue Dec 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: engine bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] dockerhub: switch to new api path Bnyro/searxng
2 participants
@return42 @Bnyro