Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Cube work with all versions of files #288

Open
albireox opened this issue Aug 8, 2017 · 3 comments
Open

Make Cube work with all versions of files #288

albireox opened this issue Aug 8, 2017 · 3 comments
Assignees
@albireox
Labels
enhancement indicates a new feature or functionality to be added marvin-tools an issue related to the suite of Marvin Python Tools priority-medium

Comments

@albireox
Copy link
Member

albireox commented Aug 8, 2017

The datamodel for Cubes is stable enough that there is probably no good reason to prevent opening a cube file from any version.This should be fairly easy to do. Right now we check whether the version of the file is in the lookup table, and fail if not. If we issue a warning instead of raising an error, I think everything else would work, although we would want to add some check to inform the user that no maps/modelcubes exist for that version if they try to open one.

This is related to #221 and #285.
@albireox albireox added enhancement indicates a new feature or functionality to be added marvin-tools an issue related to the suite of Marvin Python Tools priority-medium labels Aug 8, 2017
@albireox albireox self-assigned this Aug 8, 2017
@albireox albireox mentioned this issue Aug 8, 2017
Closed
@havok2063
Copy link
Collaborator

I think this should only be available when using the filename keyword argument.

@albireox
Copy link
Member Author

albireox commented Aug 9, 2017

Yes, because I don't think we are planning on loading cube from intermediate reductions, or any DR earlier than DR15, this should only work if you specifically ask to load that file.

@havok2063
Copy link
Collaborator

I just meant that we shouldn't make this useable via the plateifu or mangaid arguments. I think filename can be used for any cube version outside of an MPL or DR. It might not be too hard to make Marvin usable with DR13 and 14 cubes. We can just raise an error if they try to access any DAP things via it.

@albireox albireox added this to the Marvin 3.0 milestone Jul 15, 2018
@havok2063 havok2063 removed this from the Marvin 3.0 milestone Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albireox albireox

Labels
enhancement indicates a new feature or functionality to be added marvin-tools an issue related to the suite of Marvin Python Tools priority-medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@albireox @havok2063