Skydev issues110 77 #137
Open
Skydev issues110 77 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh also I tried to format the header values so they would have a limited number of decimal points. In doing so I think the values are now strings, not sure if this is important for future functions (like building the drpall file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to merge skydev_issues110_77 into main. I updated and re-organized the sky header keywords and comments. Still needs more testing and there are four more skymodel header keywords that need to be added (see comments in skymodel_pars_header to add moon ra, moon dec, moon phase, and moon illumination). Also should update how the drpall grabs these keywords (note the shadow_height keywords are now sh_hght, and several of the {telescope} is removed)