-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add every log warning emitted during reductions to header as COMMENT #133
Comments
Outstanding
|
I wouldn't recommend appending every log warning message into the headers. This could result in the headers being hundreds of fields long, filled with log comments. I would recommend using a single bitfield to capture which reduction steps a file has successfully made it through, maybe re-purposing these lvmdrp/python/lvmdrp/utils/bitmask.py Line 142 in e275d93
Alternatively, the DRP reduction log files are output in JSON format as well as text format. That makes the logs machine-readable and searchable. One could write a simple tool or script that could parse and extract information from the json logs. In my opinion, the status and quality information should be captured with something like the following header keys, which would propagate into the drpall file. This has the advantage of keeping the headers light and readable, but still tracking the details.
|
Title says it all, add every log warning emitted during reductions to header as COMMENT so that we can filter by what happened. Additionally, we will add a keyword to the headers for each step in the reductions that at least reads 'SUCCESS', 'WARNING', 'FAIL'.
The text was updated successfully, but these errors were encountered: