KYRA: Add support for Chinese EOB2 #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful for Chinese EOB2 as well
|
Wow, that's a great addition :-) . At first glance, the code changes seem unlikely to cause regressions to other versions. But it is too much to be sure, so we'll have to do some testing... |
athrxx
reviewed
Apr 27, 2023
athrxx
reviewed
Apr 28, 2023
This takes BIOS font and height-stretches it 2x just like the original
Signedness of char is platform-dependent.
This is to match original
Compared with the original in order to look as same as possible
This is more in line with the original
It's needed for EOB2 Chinese chargen to keep all the possibilities on the screen
Currently buttons have to be 8-aligned on x axis. In Chinese version it's only 4-aligned. Change code no to require any alignment.
This makes it needed for cleaning of the field when buttons are moved as needed for Chinese EOB2
It's now always zero and hence is redundant
sev-
reviewed
Apr 29, 2023
| #ifndef GRAPHICS_FONTS_DOSFONT_H | ||
| #define GRAPHICS_FONTS_DOSFONT_H | ||
|
|
||
| #include <graphics/font.h> |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.