SDL: Clip DPI scaling factor to ensure we get a reasonable value #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lephilousophe
approved these changes
Feb 11, 2023
|
Looks good to me. This will ensure that the scaling factor will always be between 1.0 and 4.0, correct? |
|
I tested this PR in my 64'' TV screen. It improved the scale, but it still too small if you using Gnome scaling (in my case it's 300%), so I needed to use a base value of |
|
Even though @neuromancer still had issues - I think this solves the potential problem for numerous users. Should we merge this as-is and backport before doing some post-release fine-tuning? |
|
This change looks good to me, it's a good compromise for unreliable system DPI scale values. Next steps (which are out of scope of this PR) would be to allow overriding DPI via our GUI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown by bug https://bugs.scummvm.org/ticket/14132, getting the DPI can be unreliable on some system, causing abnormal DPI scaling factor to be used. So I am proposing to clip the DPI scaling factor to a reasonable range. This should fix that bug since it will now return a factor of 1 instead of 0.289459 (I don't see any case where returning a value below 1 would make sense).
The change is simple, but I am creating a pull request in case I overlooked a possible issue with it.