CREATE_PROJECT: Set Xcode MACOSX_DEPLOYMENT_TARGET #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not an expert on this subject, but I confirm the issue and the reasoning looks good to me! Thanks |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac xcode builds are currently broken when using the latest xcode on anything less than the latest macos version.
We have not been setting
MACOSX_DEPLOYMENT_TARGETin the project file. This was okay before xcode 14, because xcode would use a reasonable default value. Xcode 14 changed this. Now when this property isn't set, xcode defaults to the maximum os version it's aware of. If the current os is less than this then the build fails.Xcode 14 introduced
RECOMMENDED_MACOSX_DEPLOYMENT_TARGETfor this purpose, so now we use that. This shouldn't change behavior for earlier xcode versions, but I'm not in a position to test that.