Fix dependencies on highres and 16-bit in plumbers and dreamweb #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccawley2011
reviewed
Jan 31, 2023
phcoder
force-pushed
the
plumbershalf3
branch
from
2b5481e
to
81e8593
Compare
|
@phcoder do you have time to finish it? |
This is useful in order to fallback resolutions even if supported resolution is not known at compile time.
phcoder
force-pushed
the
plumbershalf3
branch
from
81e8593
to
8c4cab6
Compare
Downscale images to 320x240 if highres is not supported.
Otherwise it leads to immediate crash on low-resolution devices.
phcoder
force-pushed
the
plumbershalf3
branch
from
8c4cab6
to
7539142
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dreamweb has undeclared dependency on highres. It's used only for titles. Downscale titles if necessary instead.
Plumbers uses highres only for the windows version. Again BMPs are simple to downscale and the windows version has no movies.
3DO version needs 16-bit but it's better to disable only 3do version if 16-bit is unavailable.
3DO and windows share almost no code and instead it's a mess of variables which are glorified platform markers. I've split windows and 3do versions of plumbers into separate classes