Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Avoid absolute pathnames in .pyx files #19123

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

bmwiedemann
Copy link
Contributor

Reference issue

Closes #19101

What does this implement/fix?

Avoid absolute pathnames in .pyx files
to allow for reproducible builds
even when (unneeded) .pyx files are installed and shipped in OS packages.

Additional information

This patch was done while working on reproducible builds for openSUSE.

to allow for reproducible builds
even when (unneeded) .pyx files are installed and shipped in OS packages

Fixes: scipy#19101

This patch was done while working on reproducible builds for openSUSE.
@j-bowhay j-bowhay added the Build issues Issues with building from source, including different choices of architecture, compilers and OS label Aug 24, 2023
@andyfaff
Copy link
Contributor

Seems like a harmless change to me, and all tests passing. Thank you @bmwiedemann

@andyfaff andyfaff merged commit 6a1871a into scipy:main Aug 24, 2023
@rgommers rgommers added this to the 1.12.0 milestone Aug 25, 2023
@rgommers rgommers added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Aug 25, 2023
@bmwiedemann bmwiedemann deleted the pyx branch August 27, 2023 15:41
@tylerjereddy tylerjereddy modified the milestones: 1.12.0, 1.11.3 Sep 21, 2023
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build issues Issues with building from source, including different choices of architecture, compilers and OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: mesonpy embeds random path in .pyx files
5 participants