Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Otsu threshold to scil_volume_math.py #887

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

CHrlS98
Copy link
Contributor

@CHrlS98 CHrlS98 commented Jan 25, 2024

Quick description

I just wanted to add an option to scil_volume_math.py for foreground/background segmentation using the Otsu threshold. This is useful (to me at least) for estimating a preliminary brain mask from my mouse brains. Requires the new dependency scikit-image.

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pep8speaks
Copy link

pep8speaks commented Jan 25, 2024

Hello @CHrlS98, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-01-25 18:33:08 UTC

@arnaudbore arnaudbore self-requested a review January 25, 2024 18:33
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a732b55) 65.74% compared to head (c9e97b3) 65.77%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #887       /-   ##
==========================================
  Coverage   65.74%   65.77%    0.03%     
==========================================
  Files         384      384              
  Lines       21321    21340       19     
  Branches     3493     3493              
==========================================
  Hits        14018    14037       19     
  Misses       5699     5699              
  Partials     1604     1604              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@arnaudbore arnaudbore merged commit 29c7968 into scilus:master Jan 25, 2024
7 checks passed
@CHrlS98 CHrlS98 deleted the volume-math branch January 25, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants