Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add coverage #869

Merged
merged 5 commits into from
Dec 15, 2023
Merged

[ENH] Add coverage #869

merged 5 commits into from
Dec 15, 2023

Conversation

arnaudbore
Copy link
Contributor

Combine with coverage jenkins plugins

@arnaudbore arnaudbore requested a review from frheault December 15, 2023 17:26
@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

AlexVCaron
AlexVCaron requested changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some little things I would change, but let's wait after the tests passes to do so and validate a first Coverage Unit Tests report in Jenkins.

Also, don't forget to add pytest-html and pytest-cov in the requirements.

Jenkinsfile Outdated Show resolved Hide resolved
pytest.ini Show resolved Hide resolved
@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore
Copy link
Contributor Author

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore merged commit 4e745b1 into scilus:master Dec 15, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexVCaron AlexVCaron AlexVCaron requested changes

@frheault frheault Awaiting requested review from frheault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaudbore @AlexVCaron