Adding legacy options to scil_convert_sh_basis.py #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build passed ! Good Job 🍻 ! |
CHrlS98
reviewed
Apr 3, 2023
|
Good point. Either ways look fine to me. I will let @arnaudbore choose ;) |
|
We can start this way and then if we want to support legacy vs non-legacy everywhere we can think of a way to integrate it in the |
arnaudbore
approved these changes
May 17, 2023
scripts/scil_convert_sh_basis.py
Outdated
| @@ -42,13 49,18 @@ def main(): | |||
| assert_inputs_exist(parser, args.in_sh) | |||
| assert_outputs_exist(parser, args, args.out_sh) | |||
|
|
|||
| print(args.is_input_not_legacy) | |||
There was a problem hiding this comment.
Remove print and add logging to verbose some info of the sh basis/legacy/not legacy...
There was a problem hiding this comment.
Not sure the verbose is necessary here... and if so, what would be the right way to do it?
|
Build passed ! Good Job 🍻 ! |
|
Build passed ! Good Job 🍻 ! |
|
Build passed ! Good Job 🍻 ! |
CHrlS98
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a small addition to the
scil_convert_sh_basis.pyscript to allow for the choice of not legacy versions of descoteaux07 and tournier07 SH bases. Previously, both bases were assumed to be legacy, which is usually the case for Dipy (descoteaux07). However, the current Mrtrix3 tools use a new version of tournier07, which is not the "legacy" one. So when converting from tournier07 with new data to descoteaux07, I got some weird little blobs at the center of my fODFs. Now, we can specify if we don't want the legacy version for the output, and if the input was coded with legacy or not.I was wondering if I should check for the input/output selected bases and choose not legacy by default for tournier07. What do you think @arnaudbore @CHrlS98 ?