Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making IconAlignment property to define without making custom style #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

making IconAlignment property to define without making custom style #6

wants to merge 4 commits into from

Conversation

iAmrSalman
Copy link

No description provided.

@schmidyy
Copy link
Owner

schmidyy commented Mar 6, 2019

Interesting proposal. I'm curious how many people would prefer having the icon on the right and still use one of the default styles.

Thanks for the PR! I'll think about this

@iAmrSalman
Copy link
Author

This will be useful for right to left languages to use default styles and be able to place the icon on the right

schmidyy
schmidyy reviewed Mar 7, 2019
View reviewed changes
Loaf/Loaf/Loaf.swift
public enum IconAlignment {
case left
case right
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to also removed the iconAlignment property from this struct too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidyy schmidyy schmidyy left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iAmrSalman @schmidyy