Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment, Question, Answer and parentItem #851

Open
tilgovi opened this issue Oct 26, 2015 · 5 comments
Open

Comment, Question, Answer and parentItem #851

tilgovi opened this issue Oct 26, 2015 · 5 comments
Assignees
@lucy-kind
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). schema.org vocab General top level tag for issues on the vocabulary status:work expected We are likely to, or would like to, or probably should try, ... to do something in this area. type:cleanup clarity Addresses wording fixes, ambiguities, confusion, bad examples etc

Comments

@tilgovi
Copy link

tilgovi commented Oct 26, 2015

It seems that #112 was resolved by 9e83707 with the upvoteCount and downvoteCount properties having their comment clarified.

However, parentItem, also mentioned in #112, seems to not be clear. It is currently a property of Answer, although its description contains language similar to upvoteCount and downvoteCount.

I see a couple ways to resolve this:

  • Clarify the comment on parentItem to state that it refers to the parent question.
  • Make Question a sub-class of Comment and move parentItem to Comment.
  • Create a common super-class for Comment and Question.
  • Move parentItem to CreativeWork.

The first of these I dislike because the property is called parentItem.

The second of these makes some sense to me.

The third of these also makes sense. It could be Communication, which could also be the object of some property of CommunicateAction.

The last would be fine, too.

In any case, the parentItem name is a little iffy, but not a big deal.
@danbri
Copy link
Contributor

danbri commented Oct 28, 2015

Thanks, yeah that property does seem a bit awkward.

Copying my forgotten comment from #112:

Also maybe "The parent of a question, answer or item in general."
 -> "The parent of a question, answer or comment item in general."? 
(http://schema.org/parentItem)

I'm not sure what is best to do here. Thanks for raising for options for discussion :)

/cc @scor who contributed on the Question/Answer work.

@danbri danbri added schema.org vocab General top level tag for issues on the vocabulary type:cleanup clarity Addresses wording fixes, ambiguities, confusion, bad examples etc labels Oct 28, 2015
@unor
Copy link
Contributor

unor commented Jul 7, 2017

bump

Not sure how exactly parentItem was defined in the past (in the OP it’s mentioned that it was defined for Answer), but now it has Comment as domain and Question as range, and its description says:

The parent of a question, answer or item in general.

… which doesn’t seem to be right.

@danbri danbri added the status:work expected We are likely to, or would like to, or probably should try, ... to do something in this area. label Jul 20, 2020
@danbri
Copy link
Contributor

danbri commented Jul 20, 2020

@lucy-kind - you just asked about this, it seems to be an overlooked error in our technical debt archives

I believe the correct definition would be

  • Comment parentItem Comment

@danbri danbri mentioned this issue Jul 20, 2020
Closed
@lucy-kind lucy-kind self-assigned this Jul 20, 2020
@github-actions
Copy link

This issue is being tagged as Stale due to inactivity.

@github-actions github-actions bot added the no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Sep 19, 2020
@KalleOlaviNiemitalo
Copy link

I believe the correct definition would be

* Comment parentItem Comment

That appears to have been implemented.

@rrlevering rrlevering mentioned this issue Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucy-kind lucy-kind

Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). schema.org vocab General top level tag for issues on the vocabulary status:work expected We are likely to, or would like to, or probably should try, ... to do something in this area. type:cleanup clarity Addresses wording fixes, ambiguities, confusion, bad examples etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tilgovi @danbri @unor @KalleOlaviNiemitalo @lucy-kind