Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing in python-native-libs and sbt-scalapy under the scalapy repo #301

Open
kiendang opened this issue Aug 25, 2022 · 2 comments
Open
Assignees

Comments

@kiendang
Copy link
Member

I think bringing in python-native-libs and sbt-scalapy under the scalapy repo benefit all 3 projects, at least in terms of CI.

python-native-libs and sbt-scalapy were developed mainly for setting up scalapy so it would be good for them to be automatically tested against any change made to scalapy. Especially considering what we previously discussed about using python-native-libs to implement a runtime hook in scalapy to make these setups works in situations without sbt e.g. embedded.

On the other hand, with python-native-libs and sbt-scalapy testing scalapy under different setups e.g. virtualenvs, windows would be much easier and we can finally include it in CI here. In fact there're already virtualenv and windows tests under the python-native-libs and sbt-scalapy repos.

Let me know what you think, will be happy to do all the work on this.

@shadaj
Copy link
Member

shadaj commented Aug 25, 2022

I think this makes sense, especially for python-native-libs with the runtime integration you mentioned. Will also be nice to have more uniform versioning across the projects.

@kiendang
Copy link
Member Author

Great. #282 would be nice to publish everything under dev.scalapy too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants