-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate Fishy Record Names in Optimizer Core #4947
Comments
I've been playing around with this and so far, I have not actually managed for the optimizer to produce a Record. Either, the local def system already resolved everything before even creating a record (this is what happened here: #4946 (comment)) or the optimizer cancelled the inlining. @sjrd how did you determine the piece of code in question is not dead code? I'm starting to suspect that it only triggers for RuntimeLong (where we have more aggressive class inlining policies). |
Replace it by In order for a record to be reified, I believe we need at least an if/else where both branches return an instance of the inline class. Or any other merge point. So that's maybe what we need to add to #4946 (comment) |
Follow-up form here:
scala-js/linker/shared/src/main/scala/org/scalajs/linker/frontend/optimizer/OptimizerCore.scala
Lines 1236 to 1240 in 244fa53
The text was updated successfully, but these errors were encountered: