Experiment: restrict allowed trees in annotations #21840
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbovel
force-pushed
the
mb/restrict-type-annotations
branch
from
009c2a4
to
a1d0910
Compare
mbovel
changed the title
mbovel
force-pushed
the
mb/restrict-type-annotations
branch
3 times, most recently
from
f2779a0
to
5455c5d
Compare
|
scala3/tests/neg-custom-args/captures/reaches2.scala Lines 4 to 5 in 5455c5d In this test,
|
|
scala3/tests/pos-macros/i7519b.scala Lines 11 to 12 in 5455c5d Another question is what to do with splices, such as in the example above. Type splices are not valid anyway, so it might be okay to also refuse splices in type annotations? |
Throw away erroneous trees to avoid unpickling issues in best-effort mode. Co-Authored-By: Kacper Korban <[email protected]>
mbovel
force-pushed
the
mb/restrict-type-annotations
branch
from
5455c5d
to
2cc6ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-basic trees in type annotations currently cause compiler crashes. This experiment introduces restrictions on the trees allowed in annotations, similar to those in Java (§9.7. Annotations).