Add .msi artifacts to release assets #21834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We were waiting to get the code-signing certificate to implement this, but since we are not getting that soon, Core Team's decision was to include the |
hamzaremmal
approved these changes
Nov 4, 2024
WojciechMazur
added
the
backport:nominated
WojciechMazur
added a commit
that referenced
this pull request
Nov 6, 2024
WojciechMazur
added a commit
that referenced
this pull request
Nov 8, 2024
Backports #21834 to the 3.6.2 branch. PR submitted by the release tooling. [skip ci]
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now include .msi files produced by
build-msi-packagein release assets including both .msi file and it's sha256Resolves #21820