Avoid spurious recompilations when unrelated constructor with default argument changes #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am deliberating on whether the PR is actually a good change to have. This particular case I shall request for review and let reviewer determine if this is actually good to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Constructor sometimes has name
<init>$default$number(e.g.<init>$default$1,<init>$default$2) instead of<init>. Hence two unrelated constructors have the same name.#288 ensured that two unrelated
<init>constructor have different names by prepending constructor name with class name, however #288 did not handle<init>$default$.Fix
Prepend
<init>$default$with the class name.c.c. #288, #578 (comment)