Include extra invalidations in initial validation to fix initial compilation error #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszwawrzyk
Since comment says "This should compile" and the test expects successful compilation after clean, I guess the incremental compilation is indeed not supposed to fail there?
Friendseeker
changed the title
|
Great work, thank you! |
This was referenced Dec 19, 2023
|
Wow, this closed a lot of tickets! 👏 |
eed3si9n
pushed a commit
that referenced
this pull request
Oct 17, 2024
Ref #1284 Fixes #1461 Fixes #1420 Also fixes com-lihaoyi/mill#3748 downstream Not sure if there's a better way to fix this? Just opening this to spark discussion The original bugs are fine, but the solution seems incorrect, and is both overly conservative (invalidating everything based on whitespace?) and not conservative enough (doesn't handle cycles with length > 2?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During initial invalidation, if a class depends on invalidated class, and some invalidated class depends on that class, also invalidate that class.
Fixes #598.
To validate the fix, minimal reproduction of the issue in #598 (comment) and #654 is included as zinc scripted test.