Handling multi-space characters (Japanese, Chinese...) width better #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. If possible, Please post some characters for testing, I'll review soon. |
|
Sure |
|
Alright, example should work now much better. I tested it for quite a bit, with mixed languages, and I didn't see any anomalies. |
|
I have taken your changes in #15 |
sayanarijit
added a commit
to sayanarijit/xplr
that referenced
this pull request
Nov 18, 2022
sayanarijit
added a commit
to sayanarijit/xplr
that referenced
this pull request
Nov 18, 2022
sayanarijit
added a commit
to sayanarijit/xplr
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #530, i added
visual_cursormethod as discussed, but currently fighting incorrect display at scroll position.Currently I'm not sure if code in example is to blame or tui-rs. Investigating.