Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning: CommonJS or AMD dependencies can cause optimization bailouts #585

Open
allanbowe opened this issue Nov 10, 2021 · 0 comments
Open

Comments

@allanbowe
Copy link
Member

Currently in the DC (Angular) build we get the following warning:

Warning: /Users/munja/git/data-controller/client/src/app/general/user-nav-dropdown/user-nav-dropdown.component.ts depends on '@sasjs/adapter'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

We're currently packaging the adapter as a commonjs module for compatibility with Node - so we can use the same package in the CLI and in browser apps.

To address the warning above, we could provide ES6 modules, additionally, in the @sasjs/adapter/esm folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant