Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ml2 drivers to start their own RPC listeners #66

Open
wants to merge 2 commits into
base: stable/yoga-m3
Choose a base branch
from

Conversation

sebageek
Copy link
Collaborator

@sebageek sebageek commented Jul 8, 2024

This is a backport of a proposed commit to upstream (which is not yet merged there). We also revert the original patch which starts workers in our neutron-rpc-servers (which we did as a crutch to start rpc listeners our ml2 drivers needed), as this is now done via the Ml2Plugin. For details, see the individual commit messages.

To allow MechanismDrivers to start their own RPC listeners (e.g. for
communication with custom agents) the MechanismManager will now call
start_rpc_listeners() of each driver. This is done as part of
Ml2Plugin.start_rpc_listeners(). It is added as an alternative to create
the backends in initialize(), as in cases where a driver is split up
into the API and RPC part we want to make sure these backends are only
started in the RPC part of neutron.

This patch depends on MechanismDrivers.start_rpc_listeners() in
neutron-lib[0].

[0] https://review.opendev.org/c/openstack/neutron-lib/ /919589

Change-Id: I31e253180f474abf6d266d23c50f9dc89f17f687
Depends-On: https://review.opendev.org/c/openstack/neutron-lib/ /919589
Closes-Bug: #2065198
We do not need to call start_rpc_workers() to start the rpc listeners of
our ml2 drivers, as these are now started via start_rpc_listeners(),
which is called from within Ml2Plugin's own start_rpc_listeners()
method.

All drivers that rely on their listeners to be started via get_workers()
and do not have a proper start_rpc_listeners() method will need to
implement one, but as most use get_workers() to just call their own
start_rpc_listeners() there shouldn't be much to be done on the driver's
side.

This reverts commit b2376f8.
@sebageek sebageek force-pushed the ml2-plugin-start-rpc-listeners branch from f34a418 to bfd911d Compare August 5, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant