Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add workflow config for auto-updating studios #7002

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

cngonzalez
Copy link
Member

@cngonzalez cngonzalez commented Jun 20, 2024

RESOLVES SDX-1412

Description

As we move to different ways of building the Studio, it's important to test all functionality across existing and new build configuration. This PR adds a matrix option for auto-updating studios (with the potential of adding more). It also adds some conditional scripting logic to ensure that studios build and run according to the matrix configuration parameter.

In addition, it adds and updates tests that depend on a studio built with the auto-updates parameter.

What to review

The changed Github workflow. I have a few specific questions:

  1. Are we okay with config: [auto-updating, default]? Are there better names for what we want to express?
  2. Should we also add logic for additional datasets depending on whether or not the studio is auto-updating?

Testing

The specific tests added in this PR should pass under both conditions. All other tests should pass under both conditions.

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 3:53pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 3:53pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 3:53pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 3:53pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 3:53pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 3:53pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jun 20, 2024

Component Testing Report Updated Jun 20, 2024 4:02 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 45s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 17s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 7s 21 0 0

@cngonzalez cngonzalez force-pushed the feat/add-workflow-config-for-AUS branch from 4f51e19 to 9cf808e Compare June 20, 2024 14:23
@cngonzalez cngonzalez force-pushed the feat/add-workflow-config-for-AUS branch from 9cf808e to 8029dd9 Compare June 20, 2024 14:40
@cngonzalez cngonzalez force-pushed the feat/add-workflow-config-for-AUS branch from 8029dd9 to 64cb096 Compare June 20, 2024 14:47
@cngonzalez cngonzalez force-pushed the feat/add-workflow-config-for-AUS branch from 64cb096 to 198eef3 Compare June 20, 2024 14:54
@cngonzalez cngonzalez force-pushed the feat/add-workflow-config-for-AUS branch from ee20778 to 5142ea8 Compare June 20, 2024 15:25
@cngonzalez cngonzalez changed the title feat: add workflow config for auto-updating studios feat(ci): add workflow config for auto-updating studios Jun 20, 2024
@cngonzalez cngonzalez force-pushed the feat/add-workflow-config-for-AUS branch from 5142ea8 to 363dbc5 Compare June 20, 2024 15:40
@cngonzalez cngonzalez force-pushed the feat/add-workflow-config-for-AUS branch from 363dbc5 to e6922c1 Compare June 20, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant