Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a pitfall in existing
FromPtrOr
that fallback value must be provided even if it is expensive to create.For example, assume
SecureRandStr
that generates secure random string:Even if
token
is notnil
,SecureRandStr
is always called.Proposal
Proposed
FromPtrOrF
accepts function that returns fallback value, rather than accept a fallback value itself:Now
SecureRandStr
is called only iftoken
is nil, saving cost to generate secure random token.