Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.7.6 breaks --fail-any-none flag #207

Open
amoskyler opened this issue Mar 21, 2020 · 1 comment
Open

Release 0.7.6 breaks --fail-any-none flag #207

amoskyler opened this issue Mar 21, 2020 · 1 comment

Comments

@amoskyler
Copy link

Since the release of 0.7.6 earlier this month --fail-any-none is exiting the application with status code 255 instead of 0. When I downgrade the package to 0.7.5 it works as expected.

All tasks in my state are completing successfully, so as you can imagine I am a bit confused. I have also had trouble finding what code changed in that release, so I'm having trouble tracking down why it is not behaving the way I expect.
@mattiasr
Copy link

I think this is related, it also worked in 0.7.5 but got broken in 0.7.6

$ pepper --fail-any -C 'G@roles:postgresql-server and G@env:foo-stage' state.apply foo.db.bar.create SALTENV=0.0.22
{
    "return": [
        {
            "cool.host.name": {
                "jid": "20200824064732796944",
                "out": "highstate",
                "ret": [
                    "No matching sls found for 'foo.db.bar.create' in env '0.0.22'"
                ],
                "retcode": 1
            }
        }
    ]
}


$ echo $?
0

With 0.7.5 it exit with 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattiasr @amoskyler