New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Leading Slash When Base URL is empty and endpoint in request is a URL #92

Merged

Sammyjo20 merged 1 commit into v1 from fix/trailing-slash-url-helper

Oct 25, 2022

Member

Sammyjo20 commented Oct 25, 2022 •

edited

Loading

This PR fixes https://github.com/Sammyjo20/saloon-laravel/issues/26


Fixed leading slash when the base url is empty

d19adbb

what-the-diff bot commented Oct 25, 2022

The URLHelper::join() method now accepts a full url as the second argument.
A new test was added to ensure that this works correctly.

Sammyjo20 commented

View reviewed changes

Member Author

Sammyjo20 left a comment

Self review

Sammyjo20 merged commit 161aadb into v1

Sammyjo20 deleted the fix/trailing-slash-url-helper branch

November 13, 2022 16:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment