Feature | Ability to overwrite OAuth2 request classes #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌟 PR Summary 🌟
Enjoy all the improvements! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239
This PR adds a few overwritable protected methods on the
AuthorizationCodeGrantandClientCredentialsGrantOAuth2 traits. These methods will allow you to overwrite the instantiation of the request classes yourself, so if you need to completely swap the classes out to your own requests, you can now do it.With future versions of Saloon, I think this should be the preferred way of modifying the request classes, including adding query parameters or changing the request body, because now we have multiple ways of modifying the requests and it may get a little confusing.