Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix | Throw FatalRequestException when Guzzle doesn't return a response in the RequestException #216

Merged
merged 2 commits into from
May 14, 2023
Merged

Fix | Throw FatalRequestException when Guzzle doesn't return a response in the RequestException #216

merged 2 commits into from
May 14, 2023

Conversation

Sammyjo20
Copy link
Member

Fixes #188

There's a scenario often found when dealing with Invalid SSL certificates that Guzzle won't throw a ConnectException, but it will throw a RequestException without a response. Saloon will now check if that response is not provided and if it's null, we will throw a FatalRequestException.

@what-the-diff
Copy link

what-the-diff bot commented May 14, 2023

PR Summary 😃

  • Improved Connection Error Handling 🚀
    Added a new exception handler to better manage situations when Guzzle struggles to connect to the host, enhancing the overall stability of our app.
  • Test Updates for Connection Error Scenario 🧪
    Updated tests to make sure the new exception handler works flawlessly, ensuring that our application stays reliable and robust. 🎉

Sammyjo20
Sammyjo20 commented May 14, 2023
View reviewed changes
Copy link
Member Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

Sammyjo20
Sammyjo20 commented May 14, 2023
View reviewed changes
Copy link
Member Author

@Sammyjo20 Sammyjo20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

@Sammyjo20 Sammyjo20 mentioned this pull request May 14, 2023
Closed
@Sammyjo20 Sammyjo20 merged commit f052978 into v2 May 14, 2023
@Sammyjo20 Sammyjo20 deleted the feature/better-error-handling-for-guzzle branch May 20, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Sammyjo20